Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Save listener duration as milliseconds #589

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Sep 4, 2024

About this PR

The listener duration is saved as seconds so it's mostly 1 or 0 depending on the app.

This is now changed to milliseconds.

Technical highlight/advice

I also changed the log pattern to have time informations.

How to test my changes

  • Create an app (could be locally with the doc that I added)
  • Run the app
  • Look at the session measurement tables

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara added the bug Something isn't working label Sep 4, 2024
@taorepoara taorepoara self-assigned this Sep 4, 2024
@taorepoara taorepoara marked this pull request as ready for review September 4, 2024 13:24
@taorepoara taorepoara changed the title fix: Save listener duration en milliseconds fix: Save listener duration as milliseconds Sep 16, 2024
@taorepoara taorepoara merged commit f1a4961 into main Sep 20, 2024
4 checks passed
@taorepoara taorepoara deleted the fix-refresh-duration branch September 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant